Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSqlStringForSqlObject method is deprecated - do not use it in documentation #248

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

paulovitorbal
Copy link
Contributor

getSqlStringForSqlObject is deprecated in 2.4. And the method comments suggest using the buildSqlString method instead.

Signed-off-by: Paulo Vitor Bettini de Paiva Lima paulovitorbal@gmail.com

Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA /no

Description

Tell us about why this change is necessary:

  • Are you adding documentation?
    • TARGET THE default 2.16.x branch

getSqlStringForSqlObject is  deprecated in 2.4. And the method comments suggest using the buildSqlString method instead.

Signed-off-by: Paulo Vitor Bettini de Paiva Lima <paulovitorbal@gmail.com>
@paulovitorbal
Copy link
Contributor Author

Sorry about my poor english. I could not understand perfectly the issue template. But I saw a small error on the documentation (method usage) and this PR fixes it. If needed I can provide more information or make changes to the code.

Glad to help.

@Ocramius Ocramius added this to the 2.16.0 milestone Jun 28, 2022
@Ocramius Ocramius self-assigned this Jun 28, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulovitorbal this is good, thanks for fixing this documentation issue! 👍

@Ocramius Ocramius changed the title getSqlStringForSqlObject method is deprecated getSqlStringForSqlObject method is deprecated - do not use it in documentation Jun 28, 2022
@Ocramius Ocramius merged commit 42e8421 into laminas:2.16.x Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants